Improve handling DecryptionErrorType.KEY_MISMATCH

[DenBond7]

Not sure. I think we can improve that in another PR too. I'll create an issue for that.

Originally posted by @DenBond7 in #1225 (comment)

[DenBond7]

  @Test
  fun testDecryptionErrorKeyMismatch() {
    val srcFile = temporaryFolder.createFileWithRandomData(fileSizeInBytes = FileUtils.ONE_MB)
    val sourceBytes = srcFile.readBytes()
    val outputStreamForEncryptedSource = ByteArrayOutputStream()
    PgpEncrypt.encryptAndOrSign(
      srcInputStream = ByteArrayInputStream(sourceBytes),
      destOutputStream = outputStreamForEncryptedSource,
      pgpPublicKeyRingCollection = PGPPublicKeyRingCollection(
        listOf(
          KeyRingUtils.publicKeyRingFrom(senderPGPSecretKeyRing),
          KeyRingUtils.publicKeyRingFrom(receiverPGPSecretKeyRing)
        )
      ),
      doArmor = false
    )

    val encryptedBytes = outputStreamForEncryptedSource.toByteArray()
    val outputStreamWithDecryptedData = ByteArrayOutputStream()
    val randomKey = PGPainless.generateKeyRing()
      .simpleEcKeyRing("random@flowcrypt.test", "qwerty")

    val exception = Assert.assertThrows(DecryptionException::class.java) {
      PgpDecrypt.decrypt(
        srcInputStream = ByteArrayInputStream(encryptedBytes),
        destOutputStream = outputStreamWithDecryptedData,
        pgpSecretKeyRingCollection = PGPSecretKeyRingCollection(listOf(randomKey)),
        protector = PasswordBasedSecretKeyRingProtector.forKey(
          randomKey,
          Passphrase.fromPassword("qwerty")
        )
      )
    }

    Assert.assertEquals(
      exception.decryptionErrorType,
      PgpDecrypt.DecryptionErrorType.KEY_MISMATCH
    )
  }

[github-actions]

There were 1 email addresses found in the above comment. Please:

1. click three dots -> edit to remove the email addresses
2. click edited in the comment header, and click on the previous revision of the comment
3. when viewing the old revision with an email in it, click options -> delete this revision from history

[DenBond7]

By the way, @seisvelas could we exclude *@flowcrypt.test from checking?

[tomholub]

Actually, every email ending .test and also example.com should be excluded by default.

[DenBond7]

#1221 (comment)

[DenBond7]

pgpainless/pgpainless#127