Conversation
|
Converting from draft to regular PR - let's anyway review it in this state. |
.../androidTest/java/com/flowcrypt/email/ui/activity/enterprise/SignInActivityEnterpriseTest.kt
Outdated
Show resolved
Hide resolved
It was compilation issues. To prevent such an issue you can use 2 ways (for both way you have to have at least 1 connected device - an emulator or a real device): If that task passes there are no compilation issues |
|
@DenBond7 thanks! I just didn't know how to run all the tests in the Android project. Sure, I will do this next times. |
Just want to clarify. My examples just print tests and don't run them. But it'll be enough to catch compilation errors |
|
ok, so you were meaning that this will not necessarily run test (due to various reasons like missing running AVD), but will try to compile everything and thus will catch compilation errors, right? |
|
Almost. Unfortunately, any of my examples will not complete if you don't have at least one connected device. For example, I'm thinking about that. Need to check all |
|
|
|
@DenBond7 No, it eventually fails: $ ./gradlew clean assemble
.....
> Task :FlowCrypt:compileConsumerReleaseKotlin FAILED
e: /home/ivan/pro/flowcrypt/flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/FlowCryptApplication.kt: (27, 8): Unresolved reference: leakcanary
e: /home/ivan/pro/flowcrypt/flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/FlowCryptApplication.kt: (123, 7): Unresolved reference: LeakCanary
e: /home/ivan/pro/flowcrypt/flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/FlowCryptApplication.kt: (123, 18): Variable expected
e: /home/ivan/pro/flowcrypt/flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/FlowCryptApplication.kt: (123, 27): Unresolved reference: LeakCanary
e: /home/ivan/pro/flowcrypt/flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/FlowCryptApplication.kt: (124, 7): Unresolved reference: LeakCanary
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':FlowCrypt:compileConsumerReleaseKotlin'.
> Compilation error. See log for more details
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 3m 4s
67 actionable tasks: 30 executed, 37 from cache |
I've found. You can use this one. It doesn't require a device.
|
|
@IvanPizhenko
|
|
@DenBond7 thanks! Just one note about "clean": it cleans the whole build output and rebuilds it again. If you are sure you are not messed up something, which is typical case, clean often can be omitted. However, if something constantly goes wrong, and looks like you have old code working instead of new, clean is the right thing to do. Otherwise incremental compilation of the only changed stuff is faster. |
|
@DenBond7 what is the difference between targets |
|
Just now found out from |


Not sure if this is completely correct. See my comment in the #868. Now just want to see if semaphore passes.