Issue 372 keep pass phrase in memory by DenBond7 · Pull Request #1249 · FlowCrypt/flowcrypt-android

DenBond7 · 2021-05-25T14:17:09Z

This PR adds a base realization of "keep pass phrase in memory" support
close #372 //

Tests (delete all except exactly one):

Tests will be added later. As it is a base realization issues for tests will be added later

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

addresses the issue it closes (if any)
code is readable and understandable
is accompanied with tests, or tests are not needed
is free of vulnerabilities

…he database version to 25. Refactored code.| #372

… it is possible. Refactored code.| #372

…yEntity.PassphraseType.RAM.| #372

…sViewModel. Refactored code.| #372

# Conflicts: # FlowCrypt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/CheckPrivateKeysViewModel.kt # FlowCrypt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/PrivateKeysViewModel.kt # FlowCrypt/src/main/java/com/flowcrypt/email/security/KeysStorageImpl.kt # FlowCrypt/src/main/java/com/flowcrypt/email/security/SecurityUtils.kt # FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpKey.kt # FlowCrypt/src/main/java/com/flowcrypt/email/service/actionqueue/actions/BackupPrivateKeyToInboxAction.kt # FlowCrypt/src/main/java/com/flowcrypt/email/service/attachment/AttachmentDownloadManagerService.kt

…Refactored code in KeysStorageImpl.| #372

… a pass phrase for passphraseType == KeyEntity.PassphraseType.RAM.| #372

tomholub · 2021-05-26T10:45:39Z

Instead of Pass phrase was erased please say Pass phrase purged from memory

tomholub · 2021-05-26T10:48:38Z

The node key caching is causing confusion indeed - just purged pass phrase from memory, but can still decrypt. Since it will take some time before we can completely drop node (while Ivan works on re-implementing parsing messages), we should consider keeping this feature enabled only on debug builds for now.

DenBond7 · 2021-05-26T10:50:40Z

The node key caching is causing confusion indeed - just purged pass phrase from memory, but can still decrypt. Since it will take some time before we can completely drop node (while Ivan works on re-implementing parsing messages), we should consider keeping this feature enabled only on debug builds for now.

Yup. I totally agree. It confuses me too.

tomholub · 2021-05-26T10:51:41Z

Is it possible to restart the node process? That would clear the cache. Otherwise I'd need to add a call for purging cache. Maybe actually there already is one.

tomholub · 2021-05-26T10:52:42Z

Unfortunately, I didn't expose this through an endpoint earlier.

tomholub · 2021-05-26T10:52:57Z

Otherwise it works as expected 👍

tomholub · 2021-05-26T10:53:19Z

(except the missing UI functionality to re-enter pass phrase in various places)

DenBond7 · 2021-05-26T10:53:40Z

Is it possible to restart the node process? That would clear the cache. Otherwise I'd need to add a call for purging cache. Maybe actually there already is one.

I'm not sure that restart it's a good idea. That process is not fast. On slow devices it can take up to 5-7 seconds

tomholub · 2021-05-26T10:54:43Z

That may be ok if it only happens when I click "forget pass phrase" - a rare thing to do

tomholub · 2021-05-26T10:55:31Z

It would allow us to start testing this new functionality with users already now before node is dropped

DenBond7 · 2021-05-26T10:56:35Z

(except the missing UI functionality to re-enter pass phrase in various places)

Yup. I've created a few issues where we can discuss that. Too many changes need to make for that.

DenBond7 · 2021-05-26T10:57:57Z

It would allow us to start testing this new functionality with users already now before node is dropped

Got it. Please let me think about that. I'll create a separate issue.

DenBond7 · 2021-05-27T07:34:59Z

it's ready for a review

DenBond7 added 30 commits May 6, 2021 21:37

Added PassPhrasesInRAMService. Refactored code.| #372

fbe8635

Dropped using 'longId'. Migrated to use only 'fingerprint'. Updated t…

015b392

…he database version to 25. Refactored code.| #372

Fixed bugs in tests.| #372

01663ed

Modified KeysStorage. Moved to use Passphrase instead of String where…

ce1da5d

… it is possible. Refactored code.| #372

Moved NodeKeyDetails to 'security.model'.| #372

6d9e714

Renamed KeyDetails.Type to KeyDetails.SourceType.| #372

efe23bf

Renamed KeyDetails to KeyImportDetails.| #372

cb0de1f

Renamed NodeKeyDetails to PgpKeyDetails.| #372

a3dc863

Refactored code.| #372

cc38ae8

Fixed refactoring errors.| #372

c0ea860

Refactored code.| #372

464a966

Refactored code.| #372

62ae248

Fixed PrivateKeysManager.| #372

24ce45d

Refactored code.| #372

35a917f

Replaced KeyEntity with PgpKeyDetails where it is possible.| #372

9755c83

Modified the database schema to store different passphrase types.| #372

138f242

Modified KeysDao to prevent saving passphrase if passphraseType == Ke…

abcfc6c

…yEntity.PassphraseType.RAM.| #372

Modified UI in CheckKeysActivity. Added some logic to CheckPrivateKey…

7cfd151

…sViewModel. Refactored code.| #372

Fixed conflicts after merge.| #372

8c8fcdc

Modified PrivateKeysViewModel to be able to store passphrase in RAM. …

91d9820

…Refactored code in KeysStorageImpl.| #372

Added auto manage of PassPhrasesInRAMService.| #372

0ea427a

Improved KeysStorageImpl.updatePassPhrasesCache().| #372

795e3a0

Modified PrivateKeyDetailsFragment to be able to update(set or erase)…

0ed46ee

… a pass phrase for passphraseType == KeyEntity.PassphraseType.RAM.| #372

Updated a notification in PassPhrasesInRAMService.| #372

ab88dd9

Fixed a bug in CheckKeysActivity. Refactored code.| #372

f07a3a0

Fixed the database migration.| #372

ec23742

Fixed a bug in KeysStorageImpl.getPGPSecretKeyRingByFingerprint().| #372

804ab80

Added some logic to KeysStorageImpl.| #372

4dedb27

Fixed a bug in AttachmentDownloadManagerService.| #372

2401ad6

DenBond7 mentioned this pull request May 26, 2021

Restart Node server when a user clear a pass phrase #1256

Closed

DenBond7 added 8 commits May 26, 2021 14:36

Fixed some tests.| #372

4a5c256

Fixed lint warnings.| #372

112df5e

Marked some code as deprecated.| #372

630961a

Renamed some strings.| #372

d9581d0

Disabled "Keep pass phrase in memory" for release builds.| #372

452f6f6

Made notifications for PassPhrasesInRAMService silent.| #372

5331914

Removed unused code.| #372

0a31363

Fixed method names.| #372

cd9b39b

DenBond7 marked this pull request as ready for review May 27, 2021 07:34

DenBond7 requested review from IvanPizhenko and seisvelas as code owners May 27, 2021 07:34

DenBond7 requested a review from tomholub May 27, 2021 07:34

tomholub approved these changes May 27, 2021

View reviewed changes

DenBond7 merged commit 4980e51 into master May 27, 2021

DenBond7 deleted the issue_372_keep_pass_phrase_in_memory branch May 27, 2021 08:08

tomholub mentioned this pull request May 27, 2021

current structure of db? #1259

Closed

Conversation

DenBond7 commented May 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR adds a base realization of "keep pass phrase in memory" support close #372 //

To be filled by reviewers

Uh oh!

tomholub commented May 26, 2021

Uh oh!

tomholub commented May 26, 2021

Uh oh!

DenBond7 commented May 26, 2021

Uh oh!

tomholub commented May 26, 2021

Uh oh!

tomholub commented May 26, 2021

Uh oh!

tomholub commented May 26, 2021

Uh oh!

tomholub commented May 26, 2021

Uh oh!

DenBond7 commented May 26, 2021

Uh oh!

tomholub commented May 26, 2021

Uh oh!

tomholub commented May 26, 2021

Uh oh!

DenBond7 commented May 26, 2021

Uh oh!

DenBond7 commented May 26, 2021

Uh oh!

DenBond7 commented May 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DenBond7 commented May 25, 2021 •

edited

Loading

This PR adds a base realization of "keep pass phrase in memory" support
close #372 //