Conversation
tomholub
reviewed
May 31, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
This looks good to me overall (didn't dig into details) 👍
...t/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/EncryptedAttMsgBlock.kt
Show resolved
Hide resolved
Collaborator
|
@IvanPizhenko I had to add some changes to fix the JUnit tests that relate to Android. Please look at them. |
# Conflicts: # FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/GenericMsgBlock.kt # FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/MsgBlockFactory.kt
DenBond7
reviewed
May 31, 2021
FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/MsgBlock.kt
Outdated
Show resolved
Hide resolved
DenBond7
requested changes
May 31, 2021
Collaborator
DenBond7
left a comment
DenBond7
left a comment
There was a problem hiding this comment.
Please look at the comments
FlowCrypt/src/main/java/com/flowcrypt/email/extensions/javax/mail/PartExt.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/response/model/node/MsgBlock.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt
Outdated
Show resolved
Hide resolved
FlowCrypt/src/test/java/com/flowcrypt/email/security/pgp/PgpMsgTest.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@DenBond7 I've made some fixes, please recheck it |
DenBond7
approved these changes
May 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces port of the function
Mime.processDecoded()from Typescript to Kotlin.close #1223 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):