Skip to content

issue #1378 WKD client timeout test#1379

Merged
DenBond7 merged 2 commits intomasterfrom
ip-1378-timeout-test
Aug 3, 2021
Merged

issue #1378 WKD client timeout test#1379
DenBond7 merged 2 commits intomasterfrom
ip-1378-timeout-test

Conversation

@IvanPizhenko
Copy link
Contributor

This PR adds timeout test for the WKD client and introduces few small fixes to the WKD client itself

close #1378

related issue #1317


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

}

@Test
fun requestTimeoutTest() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FlowCryptMockWebServerRule is not available here since this is not "Android Test". However I've looked at it and it gives me idea to use okhttp MockWebServer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that it would be better to use a mock web server instead of sockets. It will be clearer.

@IvanPizhenko IvanPizhenko force-pushed the ip-1378-timeout-test branch from eee94a4 to d1866b7 Compare August 3, 2021 08:19
@IvanPizhenko
Copy link
Contributor Author

@DenBond7 Reworked it, please have a look again.

@DenBond7 DenBond7 merged commit 8c7e6bf into master Aug 3, 2021
@DenBond7 DenBond7 deleted the ip-1378-timeout-test branch August 3, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WKD client test for request timeout

2 participants