Issue 1327 additional ekm updates#1382
Conversation
…rWhenImportingKeyFromClipboard() from CI(fails sometimes, should be improved).| #1327
|
@DenBond7 why do you add label "PR Submitted" to pull requests? I have introduced this label with intent to put it on issues to help myself to see what issues in the list of issues assigned to me are already done (but not merged & closed yet), and what are not and so can be potentially be the next thing to work on. |
| return getUserFromBaseSettings("no_backups@flowcrypt.test") | ||
| } | ||
|
|
||
| fun getUserWithOrgRules(orgRules: OrgRules): AccountEntity { |
There was a problem hiding this comment.
I suggest to rename this into getTestUserWithOrgRules.
There was a problem hiding this comment.
I'm not sure. This class is located in the tests package. So all things there relate to testing. And adding Test just will increase the method name.
If you don't have any new questions or recommendations please approve the current PR. It is blocking me a little to complete another one.
There was a problem hiding this comment.
ok, have not noticed it is in the test package
Ah... Sorry, I didn't know. I thought you have created it to mark pull requests. No prob. From now, I will not use it. |
2 participants
This PR added additional ekm updates
close #1327 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):