Conversation
IvanPizhenko
previously approved these changes
Dec 21, 2021
Contributor
IvanPizhenko
left a comment
IvanPizhenko
left a comment
There was a problem hiding this comment.
Looks good in overall, but I suggest small changes in parameter naming. See my comments.
| */ | ||
| @POST(BuildConfig.API_URL + "account/login") | ||
| suspend fun postLogin(@Body body: LoginModel, @Header("Authorization") tokenId: String): | ||
| suspend fun postLogin(@Body body: LoginModel, @Header("Authorization") idToken: String): |
Contributor
There was a problem hiding this comment.
I'd rename here and in other methods of this class idToken into authorization, because it actually contains not only token itself but the whole content of the header.
| @POST("https://fes.{domain}/api/v1/message/new-reply-token") | ||
| suspend fun getReplyTokenForPasswordProtectedMsg( | ||
| @Path("domain") domain: String, | ||
| @Header("Authorization") idToken: String |
Contributor
There was a problem hiding this comment.
same as above - rename
| @POST("https://fes.{domain}/api/v1/message") | ||
| suspend fun uploadPasswordProtectedMsgToWebPortal( | ||
| @Path("domain") domain: String, | ||
| @Header("Authorization") idToken: String, |
Contributor
There was a problem hiding this comment.
same as above - rename
IvanPizhenko
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the web portal.| #1615
This PR added Retrofit realization for sending encrypted messages through the web portal
close #1615
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):