Issue 1618 limit accepted message passwords based on password policy#1658
Conversation
…engthViewModel. Refactored code.| #1618
IvanPizhenko
left a comment
IvanPizhenko
left a comment
There was a problem hiding this comment.
I have couple of questions here
| } | ||
|
|
||
| override fun onDestroyView() { | ||
| super.onDestroyView() |
There was a problem hiding this comment.
If in onCreate() the sequence is such we first run superclass stuff then local, then, logically, destruction should do things in the opposite way. But here I see that super.onDestroyView() is called first, then some local cleanup is performed. Is it correct? If correct then why?
There was a problem hiding this comment.
:) It refers to the Fragments lifecycle. Usually, in overridden methods, we should call the super methods first to perform the basic logic that is described in the superclass. Sorry for the short answer but it's a little difficult to explain how Android works in a few lines :)
There was a problem hiding this comment.
You can read more info here https://developer.android.com/guide/components/activities/activity-lifecycle
| } | ||
|
|
||
| override fun onDestroy() { | ||
| super.onDestroy() |
There was a problem hiding this comment.
same question as above - why super.onDestroy() call comes first?
IvanPizhenko
deleted the
issue_1618_limit_accepted_message_passwords_based_on_password_policy
branch
2 participants
This PR added password policy
close #1618
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):