Skip to content

issue #1669 Validate secret keys#1676

Merged
DenBond7 merged 13 commits intomasterfrom
issue-1669-validate-private-keys
Feb 3, 2022
Merged

issue #1669 Validate secret keys#1676
DenBond7 merged 13 commits intomasterfrom
issue-1669-validate-private-keys

Conversation

@IvanPizhenko
Copy link
Contributor

@IvanPizhenko IvanPizhenko commented Feb 2, 2022

This PR adds validation for secret keys. Validation logic is provided by PGPainless.

close #1669


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review February 3, 2022 08:58
@DenBond7 DenBond7 self-requested a review as a code owner February 3, 2022 08:58
@DenBond7
Copy link
Collaborator

DenBond7 commented Feb 3, 2022

@IvanPizhenko Please look at the added changes. I will merge it if you don't request any changes.

@IvanPizhenko
Copy link
Contributor Author

@DenBond7 yes, please merge

@DenBond7 DenBond7 merged commit d594c2b into master Feb 3, 2022
@DenBond7 DenBond7 deleted the issue-1669-validate-private-keys branch February 3, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing private key packets validation when importing/retrieving private key

2 participants