Issue 1602 verify signed messages(detached)#1695
Merged
Conversation
| val a = ByteArray(100) | ||
| val r = stream.read(a) | ||
| if (r < 1) return false | ||
| val s = String(if (r == a.size) a else a.copyOf(r), StandardCharsets.US_ASCII) |
Collaborator
Author
There was a problem hiding this comment.
Are you sure? It's cut-paste from PgpMsg. I didn't change this code, just copied it.
Contributor
There was a problem hiding this comment.
Yes, I understand, but the above is a bit more optimal than what it is now.
Collaborator
Author
|
@IvanPizhenko I've marked it as "ready to review". Don't worry about tests. it seems |
IvanPizhenko
approved these changes
Feb 17, 2022
Contributor
|
@DenBond7 Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added verification for OpenPGP/MIME signed messages. unfortunately, I had to change the logic that relates to parsing data blocks.
close #1602
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):