Skip to content

Added handling revoked keys on the message compose screen#1751

Merged
DenBond7 merged 9 commits intomasterfrom
issue_1741_compose_screen_revoked_keys
Apr 22, 2022
Merged

Added handling revoked keys on the message compose screen#1751
DenBond7 merged 9 commits intomasterfrom
issue_1741_compose_screen_revoked_keys

Conversation

@DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Apr 18, 2022

This PR Added handling revoked keys on the message compose screen

close #1741

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 changed the title Added handling revoked keys on the message compose screen. Refactored… Added handling revoked keys on the message compose screen Apr 18, 2022
@DenBond7 DenBond7 marked this pull request as ready for review April 21, 2022 11:44
@DenBond7 DenBond7 requested a review from IvanPizhenko as a code owner April 21, 2022 11:44
Copy link
Contributor

@IvanPizhenko IvanPizhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, questions, suggestions and required changes. Please see my comments.

@DenBond7 DenBond7 requested a review from IvanPizhenko April 22, 2022 07:11
@DenBond7 DenBond7 merged commit 8459d4f into master Apr 22, 2022
@DenBond7 DenBond7 deleted the issue_1741_compose_screen_revoked_keys branch April 22, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test/fix how the Android app handles revoked keys from EKM

2 participants