Skip to content

Refactored pgp_pubkey.ts file#2304

Merged
tomholub merged 2 commits intomasterfrom
issue-2239-refactor-pgp_pubkey-file
Dec 9, 2019
Merged

Refactored pgp_pubkey.ts file#2304
tomholub merged 2 commits intomasterfrom
issue-2239-refactor-pgp_pubkey-file

Conversation

@michael-volynets
Copy link
Contributor

@michael-volynets michael-volynets commented Dec 9, 2019

Issue #2239
Time Spent: 1h

@michael-volynets michael-volynets changed the title Refactored pgp_pubkey.ts file (not ready) Refactored pgp_pubkey.ts file Dec 9, 2019
@michael-volynets michael-volynets marked this pull request as ready for review December 9, 2019 19:07
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really is messy, but that's not your fault. I'll need to refactor it myself, I think.

@tomholub
Copy link
Collaborator

tomholub commented Dec 9, 2019

Refactor public_key.ts to expect several several pubkey with several emails

  • expect possibly several public keys contained, render them all
  • expect that each public key possibly contains several emails, render each
  • each pubkey should have import for all emails button as well (if > 1 email)
  • on top should be import all public keys button (if > 1 public key)

@tomholub tomholub merged commit c311cc9 into master Dec 9, 2019
@tomholub tomholub added this to the 7.3.7: Bugfixes milestone Dec 9, 2019
@tomholub tomholub deleted the issue-2239-refactor-pgp_pubkey-file branch December 10, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants