Merged
Conversation
tomholub
changed the title
added 7 commits
February 27, 2020 07:44
|
This pull request introduces 2 alerts when merging 29326c4 into e4df5ce - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging d48fc80 into e4df5ce - view on LGTM.com new alerts:
|
added 15 commits
February 27, 2020 11:32
tomholub
commented
Feb 27, 2020
Collaborator
Author
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Looks good, a few things to double check and wrap up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2590
close #1500
Add Key