Added comments for ContactStore save and update methods#3551
Merged
Conversation
rrrooommmaaa
commented
Apr 11, 2021
| * The `pubkey` property will be used only to add or update a pubkey record by the pubkey fingerprint. | ||
| * Null value of `pubkey` won't affect any pubkey records. | ||
| * The `pubkeyLastCheck` property can be set to a non-null value only when `pubkey` specified | ||
| * and will be applied only to that specific pubkey record. Missing or null `pubkeyLastCheck` will |
Contributor
Author
There was a problem hiding this comment.
There is a bit inconsistent behaviour. We can reset name and lastUse properties of the contact by providing null values in the update parameter, whereas pubkeyLastCheck will be ignored if null is provided. It's impossible to reset it. Should we do property existence check on it as with other properties or leave as it is, @tomholub ?
Collaborator
There was a problem hiding this comment.
Name and lastUse should not be ever reset (no point setting name from something to null, and no point setting lastUse from something to null either). Thanks for noticing!
tomholub
approved these changes
Apr 12, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
I merged this one in - behavior change can be done in a followup PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds description to
saveandupdatemethods ofContactStore.close #3536
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):