Conversation
Contributor
Author
|
Migration may be a bit slow (it loads and parses all the OpenPGP keys in a single batch), but it will only happen if the user migrated to new 'emails' and 'pubkeys' storagewith older version of the extension |
Collaborator
|
We have added a requirement for authentication on the backend where there wasn't any. Some mock tests were forwarding requests to real backend which no longer works. I'm updating those tests. |
tomholub
previously approved these changes
May 15, 2021
tomholub
previously approved these changes
May 15, 2021
tomholub
approved these changes
May 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles revocations.
Introduces a separate store to keep fingerprints of revoked keys (as well as some arbitrary additional info).
As OpenPGP and X.509 can potentially have same cryptographic material,
revocation of
abcdefalso "revokes"abcdef-X509, as well as revocationabcdef-X509also "revokes"abcdef.Given that, it's not to safe to load OpenPGP key if there is revocation for its X.509 sibling, even setting
revokedflag manually,because it will be lost during armor/parse. So the storage simply doesn't return such keys as if they are missing in the storage.
close #3579
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):