Skip to content

Issue 206 add input fields character limit #4536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rrrooommmaaa merged 7 commits into from
Nov 28, 2022
Merged

Issue 206 add input fields character limit #4536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f748bda
add input limit on common input fields
martgil Jul 1, 2022
564e2ca
Merge remote-tracking branch 'origin/master' into issue-206-add-input…
martgil Jul 11, 2022
771be1f
add paste on the event handler (needs help)
martgil Jul 12, 2022
dedf9a4
Merge remote-tracking branch 'origin/master' into issue-206-add-input…
rrrooommmaaa Aug 11, 2022
3ab0e3f
remove event handler on message composer
martgil Nov 11, 2022
e1a0fe6
Merge remote-tracking branch 'origin/master' into issue-206-add-input…
martgil Nov 14, 2022
d1d548d
Merge remote-tracking branch 'origin/master' into issue-206-add-input…
martgil Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/chrome/elements/backup.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<div class="line">This backup is protected by your pass phrase. Please make sure
to note your pass phrase down or you may lose access to your encrypted emails!</div>
<div class="line">
<input class="input_pass_phrase" type="password" id="pass_phrase" placeholder="Enter your pass phrase..." />
<input class="input_pass_phrase" type="password" id="pass_phrase" placeholder="Enter your pass phrase..." maxlength="1000" />
<button class="button green action_test_pass">Test your Passphrase</button>
</div>
<div class="line fingerprints hide_if_compact">Key Fingerprint: <span class="fingerprint good"></span></div>
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/elements/passphrase.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ <h1 class="passphrase_text" data-test="passphrase-text"></h1>
<div class="separator"></div>
<div class="line which_key" data-test="which-key" style="display: none;"></div>
<div class="line">
<input type="text" placeholder="Enter Pass Phrase" id="passphrase" data-test="input-pass-phrase">
<input type="text" placeholder="Enter Pass Phrase" id="passphrase" data-test="input-pass-phrase" maxlength="1000">
</div>
<div class="line">
<button class="button long green action_ok" data-test="action-confirm-pass-phrase-entry">OK</button>
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/settings/modules/add_key.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ <h1>Add Private Key <span id="spinner_container"></span></h1>
.
</div>
<div class="line">
<input id="input_passphrase" class="input_passphrase" type="text" placeholder="Private Key Passphrase" />
<input id="input_passphrase" class="input_passphrase" type="text" placeholder="Private Key Passphrase" maxlength="1000" />
</div>
<div class="line">
<label class="input_passphrase_save_label hidden" data-test="input-save-passphrase-label">
Expand Down
6 changes: 3 additions & 3 deletions extension/chrome/settings/modules/change_passphrase.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<div id="step_0_enter_current" class="display_none">
<div class="line sentence">Enter your current pass phrase</div>
<div class="line">
<input id="current_pass_phrase" type="text" placeholder="Current pass phrase" data-test="input-current-pp" />
<input id="current_pass_phrase" type="text" placeholder="Current pass phrase" data-test="input-current-pp" maxlength="1000" />
</div>
<div class="line">
<button class="button long green action_test_current_passphrase" data-test="action-confirm-current-pp">continue
Expand All @@ -33,7 +33,7 @@
<div class="line ">See <a href="#" data-swal-page="/chrome/texts/passphrase_help.htm">choosing secure pass
phrases</a>.</div>
<div class="line">
<input id="new_pass_phrase" type="text" placeholder="Enter a new pass phrase" data-test="input-new-pp" />
<input id="new_pass_phrase" type="text" placeholder="Enter a new pass phrase" data-test="input-new-pp" maxlength="1000" />
</div>
<div class="line">
<button class="button long gray action_set_pass_phrase" data-test="action-show-confirm-new-pp">SET PASS PHRASE
Expand All @@ -45,7 +45,7 @@
<div id="step_2_confirm_new" class="display_none">
<div class="line">Please repeat it one more time. Make sure to note the pass phrase down.</div>
<div class="line">
<input id="new_pass_phrase_confirm" type="text" placeholder="Repeat pass phrase" data-test="input-confirm-new-pp" />
<input id="new_pass_phrase_confirm" type="text" placeholder="Repeat pass phrase" data-test="input-confirm-new-pp" maxlength="1000" />
</div>
<div class="line">
<button class="button long green action_change" data-test="action-confirm-new-pp">CONFIRM PASS PHRASE</button>
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/settings/modules/compatibility.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ <h1>OpenPGP key compatibility test</h1>
</div>

<div class="line left">
<input id="input_passphrase" class="input_passphrase" type="password" placeholder="Private Key Passphrase" style="height: 37px !important;" />
<input id="input_passphrase" class="input_passphrase" type="password" placeholder="Private Key Passphrase" style="height: 37px !important;" maxlength="1000" />
<button class="button green large action_test_key" style="float: right;">test compatibility</button>
</div>

Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/settings/modules/help.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h2>Send message to FlowCrypt developers</h2>
</div>
<br>
<div class="line">
<textarea id="input_text" placeholder="" data-test="input-feedback-message"></textarea>
<textarea id="input_text" placeholder="" data-test="input-feedback-message" maxlength="100000"></textarea>
</div>
<div class="line">
<input type="email" id="input_email" placeholder="Your email address" style="width: 316px; margin-right: 20px;" />
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/settings/modules/my_key.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
class="action_download_revocation_cert display_none" data-test="action-revoke-certificate">revocation certificate</a>
</div>
<div class="line enter_pp" style="display: none;">
<input id="input_passphrase" type="text" placeholder="Enter your pass phrase" />
<input id="input_passphrase" type="text" placeholder="Enter your pass phrase" maxlength="1000" />
</div>
<div class="line enter_pp" style="display: none;">
<button class="button green action_continue_download">download</button>
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/settings/modules/my_key_update.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
</div>
<div class="line">
<input class="input_passphrase" type="password" data-test="input-passphrase"
placeholder="Private Key Passphrase" />
placeholder="Private Key Passphrase" maxlength="1000"/>
</div>
<div class="line"><span class="button green long action_update_private_key" data-test="action-update-key">update
private key</span></div>
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/settings/modules/security.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h3>Private key pass phrase</h3>
</div>
<div class="line passphrase_entry_container" style="display: none;">
<input type="text" id="passphrase_entry" placeholder="Enter pass phrase to confirm"
data-test="input-confirm-pass-phrase" />
data-test="input-confirm-pass-phrase" maxlength="1000" />
</div>
<div class="line passphrase_entry_container" style="display: none;">
<button class="button green confirm_passphrase_requirement_change"
Expand Down
2 changes: 1 addition & 1 deletion extension/chrome/settings/modules/test_passphrase.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<div class="line">We <b class="red">STRONGLY</b> encourage you to check that you remember your passphrase
correctly.</div>
<div class="line">
<input id="password" type="text" placeholder="Your pass phrase" data-test="input-test-passphrase" />
<input id="password" type="text" placeholder="Your pass phrase" data-test="input-test-passphrase" maxlength="1000" />
</div>
<div class="line">
<button class="button green long action_verify" data-test="action-test-passphrase">VERIFY</button>
Expand Down
12 changes: 6 additions & 6 deletions extension/chrome/settings/setup.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ <h1>Set Up FlowCrypt</h1>
data-swal-page="/chrome/texts/passphrase_help.htm">choosing
secure pass phrases</a></div>
<div class="line left">
<input class="input_password" type="text" placeholder="Pass phrase" style="margin-bottom: 0;" id="step_2a_manual_create_input_password" data-test="input-step2bmanualcreate-passphrase-1" />
<input class="input_password" type="text" placeholder="Pass phrase" style="margin-bottom: 0;" id="step_2a_manual_create_input_password" data-test="input-step2bmanualcreate-passphrase-1" maxlength="1000" />
</div>
<div class="line left">
<input class="input_password2" type="text" placeholder="Repeat pass phrase" id="step_2a_manual_create_input_password2" data-test="input-step2bmanualcreate-passphrase-2" />
<input class="input_password2" type="text" placeholder="Repeat pass phrase" id="step_2a_manual_create_input_password2" data-test="input-step2bmanualcreate-passphrase-2" maxlength="1000" />
</div>

<div class="line left">
Expand Down Expand Up @@ -195,7 +195,7 @@ <h1>Set Up FlowCrypt</h1>
a random one</a>.
</div>
<div class="line left">
<input class="input_passphrase" type="text" placeholder="Private Key Passphrase" id="step_2b_manual_enter_passphrase" data-test="input-step2bmanualenter-passphrase" />
<input class="input_passphrase" type="text" placeholder="Private Key Passphrase" id="step_2b_manual_enter_passphrase" data-test="input-step2bmanualenter-passphrase" maxlength="1000" />
</div>
<div class="line left">
<label class="input_passphrase_save_label hidden" data-test="input-step2bmanualenter-save-passphrase-label">
Expand Down Expand Up @@ -231,10 +231,10 @@ <h1>Set Up FlowCrypt</h1>
data-swal-page="/chrome/texts/passphrase_help.htm">choosing
secure pass phrases</a></div>
<div class="line">
<input class="input_password" type="text" placeholder="Pass phrase" id="step_2_ekm_input_password" data-test="input-step2ekm-passphrase-1" />
<input class="input_password" type="text" placeholder="Pass phrase" id="step_2_ekm_input_password" data-test="input-step2ekm-passphrase-1" maxlength="1000" />
</div>
<div class="line">
<input class="input_password2" type="text" placeholder="Repeat pass phrase" data-test="input-step2ekm-passphrase-2" id="step_2_ekm_input_password2" />
<input class="input_password2" type="text" placeholder="Repeat pass phrase" data-test="input-step2ekm-passphrase-2" id="step_2_ekm_input_password2" maxlength="1000" />
</div>

<div class="line">
Expand All @@ -254,7 +254,7 @@ <h1>Set Up FlowCrypt</h1>
<div class="line recovery_status">Found <span class="backups_count_words"></span> of your account key. Enter your
pass phrase to continue.</div>
<div class="wide line recovery_passphrase_container">
<input type="text" id="recovery_password" placeholder="Enter your pass phrase" data-test="input-recovery-pass-phrase" />
<input type="text" id="recovery_password" placeholder="Enter your pass phrase" data-test="input-recovery-pass-phrase" maxlength="1000" />
</div>
<div class="wide line">
<button class="button green longer action_recover_account" data-test="action-recover-account">RECOVER ACCOUNT</button>
Expand Down