Conversation
|
Most of the scenarios are covered now. |
|
Ping @tomholub |
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Thank you - various comments that will help me with code comprehension. Many apply already to the original code but this PR highlighted the need to rename them.
extension/js/common/helpers.ts
Outdated
| const clientConfiguration = await ClientConfiguration.newInstance(acctEmail); | ||
| if (replaceKeys) { | ||
| await KeyStore.set(acctEmail, await Promise.all(prvs.map(KeyUtil.keyInfoObj))); // todo: duplicate identities | ||
| // todo: should we delete passphrases matching the deleted keys? |
There was a problem hiding this comment.
Yes, especially for stored ones. But anyway also removing the memory ones is the same amount of work.
|
@rrrooommmaaa is it ready for final review? There's something still going on with tests, and it looks like a git merge is in order. |
Yes, it is ready. I think it's reacting to |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 4313719 | Google OAuth2 Keys | c355519 | extension/js/common/api/email-provider/gmail/google-auth.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
So far good, still some reviewing to do.
Some tests are acting flaky indeed |
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
With a comment - please see below
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
All looks good to me, good to merge once tests are passing
|
Ah, GitGuardian |
2 participants
This PR removes keys not present on EKM, redirects to setup page in case no keys are in the storage,
or silently generates a new key in case
PASS_PHRASE_QUIET_AUTOGENflag is present.Also, correctly sets up passphrases for newly added keys (based on the location of an existing key's pass phrase)
close #4596
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):