#5308 Fix the error when sending password-protected emails that contain emojis by martgil · Pull Request #5321 · FlowCrypt/flowcrypt-browser

martgil · 2023-07-23T09:26:40Z

This PR adds .stripEmojis() to strip out emojis of the recipient contact's name.

close #5308

Tests (delete all except exactly one):

Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

addresses the issue it closes (if any)
code is readable and understandable
is accompanied with tests, or tests are not needed
is free of vulnerabilities
is documented clearly and usefully, or doesn't need documentation

…ipient-email-containing-emoji

martgil · 2023-07-29T06:58:15Z

Manual test:

Screencast.from.2023-07-29.14-57-12.webm

martgil · 2023-07-29T06:58:31Z

@sosnovsky ready for review. thank you.

…ipient-email-containing-emoji

sosnovsky

Works well 👍 Just a couple small improvements needed

extension/js/common/platform/xss.ts

extension/chrome/elements/compose-modules/compose-input-module.ts

extension/js/common/platform/xss.ts

martgil · 2023-08-02T07:24:26Z

ready for review again. thank you.

martgil · 2023-08-02T08:11:17Z

marking back to draft state a better solution can be discussed at #5308

…l-sending-issue-for-recipient-email-containing-emoji

martgil · 2023-09-27T11:43:34Z

@sosnovsky Ready for review. thank you!

extension/js/common/platform/xss.ts

extension/chrome/elements/compose-modules/compose-input-module.ts

test/source/tests/compose.ts

…ipient-email-containing-emoji

martgil · 2023-09-30T11:59:59Z

@sosnovsky ready for review. thank you!

extension/chrome/elements/compose-modules/compose-recipients-module.ts

extension/chrome/elements/compose-modules/formatters/encrypted-mail-msg-formatter.ts

test/source/tests/compose.ts

…l-sending-issue-for-recipient-email-containing-emoji

extension/chrome/elements/compose-modules/compose-recipients-module.ts

extension/js/common/api/account-servers/external-service.ts

test/source/mock/google/strategies/send-message-strategy.ts

martgil · 2023-10-03T07:08:11Z

@sosnovsky This should be all good and ready to merge. thanks!

sosnovsky

Yeah, all good now 👍

add Xss.stripEmojis()

d708e73

martgil requested a review from sosnovsky as a code owner July 23, 2023 09:26

martgil marked this pull request as draft July 23, 2023 09:26

martgil changed the title ~~#5308 Fix the error when sending password-protected emails that contain emojis.~~ #5308 Fix the error when sending password-protected emails that contain emojis Jul 23, 2023

martgil and others added 4 commits July 23, 2023 18:38

add test

063cae6

Merge branch 'master' into issue-5308-fix-email-sending-issue-for-rec…

703fde4

…ipient-email-containing-emoji

Merge branch 'master' into issue-5308-fix-email-sending-issue-for-rec…

73f31bf

…ipient-email-containing-emoji

update compose.ts

83eb2ee

martgil marked this pull request as ready for review July 29, 2023 06:53

Merge branch 'master' into issue-5308-fix-email-sending-issue-for-rec…

38715e1

…ipient-email-containing-emoji

sosnovsky reviewed Jul 31, 2023

View reviewed changes

extension/js/common/platform/xss.ts Outdated Show resolved Hide resolved

extension/chrome/elements/compose-modules/compose-input-module.ts Outdated Show resolved Hide resolved

martgil added 2 commits July 31, 2023 17:55

store recipient info to recipientObj

271aca3

add emojiRegex lib

b3306c6

martgil marked this pull request as draft July 31, 2023 10:51

martgil added 3 commits July 31, 2023 19:35

update reference

04f8de1

github ci test

140bfc1

remove github ci test

4157117

martgil commented Aug 2, 2023

View reviewed changes

extension/js/common/platform/xss.ts Outdated Show resolved Hide resolved

add webpack configuration emoji-regex

c987f0c

martgil marked this pull request as ready for review August 2, 2023 07:24

martgil requested a review from sosnovsky August 2, 2023 07:24

martgil marked this pull request as draft August 2, 2023 08:10

sosnovsky mentioned this pull request Aug 2, 2023

Unable to send password messages if the contact name retrieved from contacts.google.com includes emoji #5308

Closed

martgil added 3 commits September 27, 2023 10:55

Merge remote-tracking branch 'origin/master' into issue-5308-fix-emai…

74b1caf

…l-sending-issue-for-recipient-email-containing-emoji

remove emoji-regex package

f06e358

add Intl.Segmenter polyfill

fa17ce5

martgil added 2 commits September 27, 2023 18:17

remove Intl.Segmenter polyfill

6a21f97

revert changes on build.sh

10fe721

martgil marked this pull request as ready for review September 27, 2023 11:43

sosnovsky reviewed Sep 28, 2023

View reviewed changes

extension/js/common/platform/xss.ts Show resolved Hide resolved

extension/chrome/elements/compose-modules/compose-input-module.ts Outdated Show resolved Hide resolved

test/source/tests/compose.ts Show resolved Hide resolved

martgil marked this pull request as draft September 28, 2023 11:50

martgil and others added 3 commits September 29, 2023 19:39

pr reviews: code simplification

a4f456e

Merge branch 'master' into issue-5308-fix-email-sending-issue-for-rec…

690e234

…ipient-email-containing-emoji

pr reviews: better test checking

75250df

martgil marked this pull request as ready for review September 30, 2023 11:58

martgil requested a review from sosnovsky September 30, 2023 11:59

sosnovsky reviewed Sep 30, 2023

View reviewed changes

extension/chrome/elements/compose-modules/compose-recipients-module.ts Outdated Show resolved Hide resolved

extension/chrome/elements/compose-modules/formatters/encrypted-mail-msg-formatter.ts Outdated Show resolved Hide resolved

test/source/tests/compose.ts Outdated Show resolved Hide resolved

martgil added 2 commits October 2, 2023 15:22

Merge remote-tracking branch 'origin/master' into issue-5308-fix-emai…

0d7fec5

…l-sending-issue-for-recipient-email-containing-emoji

pr reviews: code and test simplification

c600479

martgil requested a review from sosnovsky October 2, 2023 09:27

sosnovsky reviewed Oct 2, 2023

View reviewed changes

martgil added 2 commits October 2, 2023 18:45

pr reviews: revert other changes

35bd5fe

revert unrelated change

40106cf

martgil requested a review from sosnovsky October 3, 2023 04:38

sosnovsky reviewed Oct 3, 2023

View reviewed changes

test/source/mock/google/strategies/send-message-strategy.ts Outdated Show resolved Hide resolved

cleanup

31106ad

martgil mentioned this pull request Oct 3, 2023

bad CC returned on pasted email in cc field when sending a password messages #5309

Closed

martgil requested a review from sosnovsky October 3, 2023 07:08

sosnovsky approved these changes Oct 3, 2023

View reviewed changes

sosnovsky merged commit c75fca5 into master Oct 3, 2023

sosnovsky deleted the issue-5308-fix-email-sending-issue-for-recipient-email-containing-emoji branch October 3, 2023 07:09

Conversation

martgil commented Jul 23, 2023 • edited by sosnovsky Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To be filled by reviewers

Uh oh!

martgil commented Jul 29, 2023

Uh oh!

martgil commented Jul 29, 2023

Uh oh!

sosnovsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martgil commented Aug 2, 2023

Uh oh!

martgil commented Aug 2, 2023

Uh oh!

martgil commented Sep 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martgil commented Sep 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martgil commented Oct 3, 2023

Uh oh!

sosnovsky left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

martgil commented Jul 23, 2023 •

edited by sosnovsky

Loading