avoid test-specific delays in prod code

[tomholub]

There must be a more reasonable way to fix the issue. It could be a change to test code or production code (maybe the flow would have to be changed to be easier to test, idk).

Originally posted by @tomholub in #1510 (comment)

[tomholub]

[tomholub]

Please see if a more gracious fix can be done if you remove the workaround above

[sosnovsky]

@sosnovsky I think if we fix this issue, #1532 build failure issue will also be fixed.

Probably, but we'll need to re-check once this fix is implemented.

[sosnovsky]

@tomholub I fixed this issue in 58441a0, but now users who store passphrase only in memory will see modal asking for passphrase on every app start. It can be annoying, I think.

What about refreshing keys when user enters passphrase for the first time (for example, on opening of encrypted email or when composing new message)?

[sosnovsky]

@ioanmo226 yeah, you're right - after successful refresh I don't see this popup on startup anymore.
Then everything is ok, no annoying modal 👍

[sosnovsky]

By the way @sosnovsky, semaphoreci ui test failure issue is because of refreshKeysFromEKMIfNeeded called in SideMenuNavigationControll init method instead of viewDidAppear?

I think yes, as in mock environment response is received before UI is loaded and that's why alert can't be presented.