SwiftFormat doesn't work

[Kharchevskyi]

make format doesn't work, issue introduced in #529

[tomholub]

Could you share more details? Does it crash, print any error?

[Kharchevskyi]

Previously make format was one of our build phase, so in case someone wrote code which doesn't fit the rule in Scripts/format file swiftformat will automatically fix this.
This functionality doesn't work anymore.

[tomholub]

Meaning it no longer runs during build automatically. @sosnovsky how do you use swiftformat, to make sure pushed code is compliant?

[sosnovsky]

make format is still presented in Build Phases, but for some reason it doesn't re-format any files, I'll check what's wrong with configuration

[sosnovsky]

@Kharchevskyi I checked swiftformat setup guide for build phase (https://github.com/nicklockwood/SwiftFormat#xcode-build-phase) and it says

NOTE: Adding this script will overwrite your source files as you work on them, which has the annoying side-effect of clearing the undo history. You may wish to add the script to your test target rather than your main target, so that it is invoked only when you run the unit tests, and not every time you build the app.

Maybe it'll be better to configure swiftformat to run on CI(https://github.com/nicklockwood/SwiftFormat#on-ci-using-danger), so local files won't be overwritten, what do you think?

[tomholub]

Then the CI would be updating files on git? That may be even more annoying, you have to pull every time you push, may end up with merge conflicts all the time.

[tomholub]

I guess you could have a bot that creates PRs only against master whenever there's something to reformat.