storage error screen uses UIKit - guidance with ADK

[tomholub]

Unfortunately I fail to make this screen using ADK so I switched to pure UIKit.

Originally posted by @ivan-ushakov in #761 (comment)

What was the issue you were having?

[ivan-ushakov]

My issue was mostly with layout. I know how to make desired layout with UIKit but ADK uses another system - specs.

[tomholub]

It's not good to mix mechanisms if we can avoid it. Could you ask a more specific question about the issue you were running into? @Kharchevskyi should be able to help.

[tomholub]

@Kharchevskyi or does this really matter? Is it expected that some parts of the app use UIKit instead of ADK?

[ivan-ushakov]

Sure. I need following layout:

label
|
text view
|
button

I want label height to be auto computed based on width and text. I want button to be fixed height. I want text view to fill the space between label and button.

[Kharchevskyi]

I would suggest to use only ADK for UI and not mix with UIkit if possible.
Maybe later we can switch to SwifUI, but now I would suggest to use ADK
@ivan-ushakov Can you please take a look into FlowCryptUI and check layout for other screens.
Basically ADK will compute height for you, based on provided text in label, same as for text view.
I would suggest to use ASStackLayoutSpec (similar to UIStackView) and layout this 3 elements
Please let me know how I can help you, or you can contact me in DM and we will take a look together. Same you can check docs from Readme

[tomholub]

Don't DM. The conversation should exactly be here for future reference.

[tomholub]

Ok to give SwiftUI a try in the future but can't afford the code churn right now - need to get the app stable first.

Can evaluate it around June 2022, when our UI tests are comprehensive and we have spare dev cycles.

[ivan-ushakov]

@Kharchevskyi
I understand that you are busy with another important task now. When you will have time, could you please provide example for layout above? I tried to use ASStackLayoutSpec spec and pure ASViewController<ADisplayNode> but without any success.

[tomholub]

@ivan-ushakov could you make a draft PR with an example of what you tried? That way it will be easier for Anton to help - I think.