more crashes from 0.3.2 - when encrypting drafts

[tomholub]

these may be various users

testflight_feedback4.zip
testflight_feedback5.zip
testflight_feedback6.zip
testflight_feedback7.zip
testflight_feedback8.zip

[ivan-ushakov]

--- testflight_feedback5/crashlog.crash
Thread 0 name:
Thread 0 Crashed:
0   JavaScriptCore                      0x000000018e48d2f4 slow_path_mul + 996 (Operations.h:586)
1   JavaScriptCore                      0x000000018e48cf54 slow_path_mul + 68 (CommonSlowPaths.cpp:648)
2   JavaScriptCore                      0x000000018db96d54 0x18d94a000 + 2411860
3   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
4   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
5   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
6   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
7   JavaScriptCore                      0x000000018db8fbec vmEntryToJavaScript + 264
8   JavaScriptCore                      0x000000018e233130 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 460 (JITCodeInlines.h:42)
9   JavaScriptCore                      0x000000018e461624 JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 156 (CallData.cpp:57)
10  JavaScriptCore                      0x000000018e567078 JSC::JSMicrotask::run(JSC::JSGlobalObject*) + 412 (JSMicrotask.cpp:93)
11  JavaScriptCore                      0x000000018e6999e4 JSC::VM::drainMicrotasks() + 248 (VM.cpp:1407)
12  JavaScriptCore                      0x000000018e5660e8 JSC::JSLock::willReleaseLock() + 148 (JSLock.cpp:221)
13  JavaScriptCore                      0x000000018e565b0c JSC::JSLockHolder::~JSLockHolder() + 136 (JSLock.cpp:190)
14  JavaScriptCore                      0x000000018d94b728 -[JSValue callWithArguments:] + 520 (JSValue.mm:522)
15  FlowCrypt                           0x0000000104356850 0x1042c0000 + 616528 (Core.swift:241)
16  FlowCrypt                           0x0000000104353df4 0x1042c0000 + 605684
17  FlowCrypt                           0x00000001042e3c21 (1) await resume partial function for ComposeMessageService.encryptAndSaveDraft(message:threadId:) + 1 (ComposeMessageService.swift:149)

--- testflight_feedback6/crashlog.crash
Thread 0 name:
Thread 0 Crashed:
0   JavaScriptCore                      0x000000018e48d2f4 slow_path_mul + 996 (Operations.h:586)
1   JavaScriptCore                      0x000000018e48cf54 slow_path_mul + 68 (CommonSlowPaths.cpp:648)
2   JavaScriptCore                      0x000000018db96d54 0x18d94a000 + 2411860
3   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
4   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
5   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
6   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
7   JavaScriptCore                      0x000000018db8fbec vmEntryToJavaScript + 264
8   JavaScriptCore                      0x000000018e233130 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 460 (JITCodeInlines.h:42)
9   JavaScriptCore                      0x000000018e461624 JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 156 (CallData.cpp:57)
10  JavaScriptCore                      0x000000018e567078 JSC::JSMicrotask::run(JSC::JSGlobalObject*) + 412 (JSMicrotask.cpp:93)
11  JavaScriptCore                      0x000000018e6999e4 JSC::VM::drainMicrotasks() + 248 (VM.cpp:1407)
12  JavaScriptCore                      0x000000018e5660e8 JSC::JSLock::willReleaseLock() + 148 (JSLock.cpp:221)
13  JavaScriptCore                      0x000000018e565b0c JSC::JSLockHolder::~JSLockHolder() + 136 (JSLock.cpp:190)
14  JavaScriptCore                      0x000000018d94b728 -[JSValue callWithArguments:] + 520 (JSValue.mm:522)
15  FlowCrypt                           0x0000000104356850 0x1042c0000 + 616528 (Core.swift:241)
16  FlowCrypt                           0x0000000104353df4 0x1042c0000 + 605684
17  FlowCrypt                           0x00000001042e3c21 (1) await resume partial function for ComposeMessageService.encryptAndSaveDraft(message:threadId:) + 1 (ComposeMessageService.swift:149)

--- testflight_feedback7/crashlog.crash
Thread 0 name:
Thread 0 Crashed:
0   JavaScriptCore                      0x000000018de02c9c JSC::CodeBlock::binaryArithProfileForPC(JSC::Instruction const*) + 332 (BytecodeStructs.h:13544)
1   JavaScriptCore                      0x000000018e48e304 slow_path_div + 1348 (CommonSlowPaths.cpp:557)
2   JavaScriptCore                      0x000000018db96aa8 0x18d94a000 + 2411176
3   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
4   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
5   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
6   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
7   JavaScriptCore                      0x000000018db8fbec vmEntryToJavaScript + 264
8   JavaScriptCore                      0x000000018e233130 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 460 (JITCodeInlines.h:42)
9   JavaScriptCore                      0x000000018e461624 JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 156 (CallData.cpp:57)
10  JavaScriptCore                      0x000000018e567078 JSC::JSMicrotask::run(JSC::JSGlobalObject*) + 412 (JSMicrotask.cpp:93)
11  JavaScriptCore                      0x000000018e6999e4 JSC::VM::drainMicrotasks() + 248 (VM.cpp:1407)
12  JavaScriptCore                      0x000000018e5660e8 JSC::JSLock::willReleaseLock() + 148 (JSLock.cpp:221)
13  JavaScriptCore                      0x000000018e565b0c JSC::JSLockHolder::~JSLockHolder() + 136 (JSLock.cpp:190)
14  JavaScriptCore                      0x000000018d94b728 -[JSValue callWithArguments:] + 520 (JSValue.mm:522)
15  FlowCrypt                           0x0000000102fc2850 Core.call(_:jsonData:data:) + 852 (Core.swift:241)
16  FlowCrypt                           0x0000000102fbfdf4 Core.call(_:jsonDict:data:) + 76 (Core.swift:231)
17  FlowCrypt                           0x0000000102fbfdf4 Core.composeEmail(msg:fmt:) + 2116 (Core.swift:170)
18  FlowCrypt                           0x0000000102f4fc21 (1) await resume partial function for ComposeMessageService.encryptAndSaveDraft(message:threadId:) + 1 (ComposeMessageService.swift:149)

--- testflight_feedback8/crashlog.crash 
Thread 0 name:
Thread 0 Crashed:
0   JavaScriptCore                      0x000000018db9aa60 0x18d94a000 + 2427488
1   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
2   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
3   JavaScriptCore                      0x000000018dbb4624 llint_entry + 149404
4   JavaScriptCore                      0x000000018dbb46d8 llint_entry + 149584
5   JavaScriptCore                      0x000000018db8fbec vmEntryToJavaScript + 264
6   JavaScriptCore                      0x000000018e233130 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 460 (JITCodeInlines.h:42)
7   JavaScriptCore                      0x000000018e461624 JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 156 (CallData.cpp:57)
8   JavaScriptCore                      0x000000018e567078 JSC::JSMicrotask::run(JSC::JSGlobalObject*) + 412 (JSMicrotask.cpp:93)
9   JavaScriptCore                      0x000000018e6999e4 JSC::VM::drainMicrotasks() + 248 (VM.cpp:1407)
10  JavaScriptCore                      0x000000018e5660e8 JSC::JSLock::willReleaseLock() + 148 (JSLock.cpp:221)
11  JavaScriptCore                      0x000000018e565b0c JSC::JSLockHolder::~JSLockHolder() + 136 (JSLock.cpp:190)
12  JavaScriptCore                      0x000000018d94b728 -[JSValue callWithArguments:] + 520 (JSValue.mm:522)
13  FlowCrypt                           0x0000000104dfe850 Core.call(_:jsonData:data:) + 852 (Core.swift:241)
14  FlowCrypt                           0x0000000104dfbdf4 Core.call(_:jsonDict:data:) + 76 (Core.swift:231)
15  FlowCrypt                           0x0000000104dfbdf4 Core.composeEmail(msg:fmt:) + 2116 (Core.swift:170)
16  FlowCrypt                           0x0000000104d8bc21 (1) await resume partial function for ComposeMessageService.encryptAndSaveDraft(message:threadId:) + 1 (ComposeMessageService.swift:149)

Looks like something happens when we encrypt draft. Since we do it quite often (1 second), maybe we have some kind of resource leak

[tomholub]

We shouldn't actually be encrypting the draft every second. We should only be encrypting a draft if the content changed from last second to the next.

And even then, we should probably change it to check once in 5 seconds, and one last time when we tap the back icon. I'll file a separate issue.

[tomholub]

Resource leak is possible though, and should be looked into separately.