Skip to content

added test for reply email#1016

Merged
tomholub merged 2 commits intomasterfrom
tests/issue-973(reply)
Nov 15, 2021
Merged

added test for reply email#1016
tomholub merged 2 commits intomasterfrom
tests/issue-973(reply)

Conversation

@fcvakintos
Copy link
Contributor

@fcvakintos fcvakintos commented Nov 15, 2021

This PR contains test for checking reply email
close #937


Tests

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub
Copy link
Collaborator

tomholub commented Nov 15, 2021

@fcvakintos thank you - which IDE do you use for editting? I suppose vscode? I have added a workspace file https://github.com/FlowCrypt/flowcrypt-ios/blob/master/flowcrypt-ios.code-workspace - if you open the project using that file instead of "as a folder", the IDE should use consistent settings between my and your edits (eg tab size of 2).

Also, the IDE will suggest a linting plugin for you to catch missing awaits.

@tomholub
Copy link
Collaborator

There is also autoformat on save enabled. With that, if you go to each of the files in https://github.com/FlowCrypt/flowcrypt-ios/pull/1016/files and hit CTRL+S, and then commit that here, the diff in this PR should be much smaller (~ 5 files).

@fcvakintos
Copy link
Contributor Author

I use WebStorm

@tomholub
Copy link
Collaborator

I see. If you'll continue using WebStorm, please set indent of two spaces, so that it wouldn't collide with my settings. Then have it reformat the project.

@fcvakintos
Copy link
Contributor Author

@tomholub pushed fixes

@tomholub tomholub merged commit 26a9a70 into master Nov 15, 2021
@tomholub tomholub deleted the tests/issue-973(reply) branch November 15, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui test for tapping the reply icon

3 participants