Conversation
|
@fcvakintos thank you - which IDE do you use for editting? I suppose vscode? I have added a workspace file https://github.com/FlowCrypt/flowcrypt-ios/blob/master/flowcrypt-ios.code-workspace - if you open the project using that file instead of "as a folder", the IDE should use consistent settings between my and your edits (eg tab size of 2). Also, the IDE will suggest a linting plugin for you to catch missing awaits. |
|
There is also autoformat on save enabled. With that, if you go to each of the files in https://github.com/FlowCrypt/flowcrypt-ios/pull/1016/files and hit CTRL+S, and then commit that here, the diff in this PR should be much smaller (~ 5 files). |
|
I use WebStorm |
|
I see. If you'll continue using WebStorm, please set indent of two spaces, so that it wouldn't collide with my settings. Then have it reformat the project. |
|
@tomholub pushed fixes |
This PR contains test for checking reply email
close #937
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):