added wdio-video-reporter for failed spec video recording#1065
Merged
added wdio-video-reporter for failed spec video recording#1065
Conversation
Collaborator
Author
|
I also increased test timeouts in #1043 which should merge to master in about an hour or so. |
…il subject, added fixes for video-reporter
tomholub
commented
Nov 23, 2021
Comment on lines
39
to
45
| clickCreateEmail = async () => { | ||
| if (await (await this.createEmailButton).isDisplayed() !== true ) { | ||
| await TouchHelper.scrollDown(); | ||
| await (await this.createEmailButton).waitForDisplayed(); | ||
| } | ||
| await ElementHelper.waitAndClick(await this.createEmailButton); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This is interesting - the create email button always hovers in the same space. Why is it needed to scroll down before we can tap it? (in actual app, I don't need to scroll to see/tap the button)
Contributor
There was a problem hiding this comment.
appium doesn't see the button until you scroll in case we have full list of emails. Ask maybe devs why it could be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've merged the last PR prematurely, and reverted the change. Please see if the failing tests below are related to this PR (it seemed so) and if so, please address it.
close #1052
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):