Conversation
tomholub
commented
Nov 23, 2021
Comment on lines
39
to
44
| clickCreateEmail = async () => { | ||
| if (await (await this.createEmailButton).isDisplayed() !== true ) { | ||
| await browser.pause(2000); // todo: loading inbox. Fix this: wait until loader gone | ||
| if (await (await this.createEmailButton).isDisplayed() !== true) { | ||
| await TouchHelper.scrollDown(); | ||
| await (await this.createEmailButton).waitForDisplayed(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This needs a more proper fix - in inbox we should wait until loader is gone before interacting with/looking for the elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve running tests on my device.
issue #1070
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):