Merged
Conversation
Collaborator
|
Thanks! Please also take some screenshots for reference. |
Collaborator
Author
For sure, currently finishing some last fixes before sending to review |
Collaborator
Author
Collaborator
|
This is great. |
# Conflicts: # FlowCrypt/Functionality/DataManager/DataService.swift
tomholub
previously approved these changes
Dec 3, 2021
tomholub
previously approved these changes
Dec 3, 2021
tomholub
previously approved these changes
Dec 3, 2021
Collaborator
|
I'll update this to master to merge my changes. (there still seems to be one test left to fix later, anyway) |
Collaborator
|
No conflicts, miraculously |
tomholub
approved these changes
Dec 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR includes
close #921
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):