Skip to content

#921 Recipients list improvements#1142

Merged
tomholub merged 16 commits intomasterfrom
feature/issue-921-conversation-view
Dec 4, 2021
Merged

#921 Recipients list improvements#1142
tomholub merged 16 commits intomasterfrom
feature/issue-921-conversation-view

Conversation

@sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Dec 2, 2021

This PR includes

  • 'To: ..." field for expanded messages
  • detailed view with "To: ...", "Cc: ...", "Bcc: ..." recipients
  • updated labels for 'Sent' screen with list of all recipients

close #921


Tests (delete all except exactly one):

  • Tests added or updated - added ui test for checking recipients list

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub
Copy link
Collaborator

tomholub commented Dec 2, 2021

Thanks! Please also take some screenshots for reference.

@sosnovsky
Copy link
Collaborator Author

Thanks! Please also take some screenshots for reference.

For sure, currently finishing some last fixes before sending to review

@sosnovsky
Copy link
Collaborator Author

Default collapsed state
Simulator Screen Shot - iPhone 12 - 2021-12-02 at 17 43 15

Expanded view after user tapped on recipients line
Simulator Screen Shot - iPhone 12 - 2021-12-02 at 17 43 20

@tomholub
Copy link
Collaborator

tomholub commented Dec 2, 2021

This is great.

@sosnovsky sosnovsky requested a review from tomholub December 3, 2021 14:16
@sosnovsky sosnovsky marked this pull request as ready for review December 3, 2021 14:18
tomholub
tomholub previously approved these changes Dec 3, 2021
tomholub
tomholub previously approved these changes Dec 3, 2021
@tomholub tomholub enabled auto-merge (squash) December 3, 2021 20:42
tomholub
tomholub previously approved these changes Dec 3, 2021
@tomholub
Copy link
Collaborator

tomholub commented Dec 4, 2021

I'll update this to master to merge my changes. (there still seems to be one test left to fix later, anyway)

@tomholub
Copy link
Collaborator

tomholub commented Dec 4, 2021

No conflicts, miraculously

@tomholub tomholub merged commit 2ef7863 into master Dec 4, 2021
@tomholub tomholub deleted the feature/issue-921-conversation-view branch December 4, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gmail conversation view - it's not clear to whom each message was sent

2 participants