Skip to content

added new spec for cancel login + login + logout#1202

Merged
sosnovsky merged 1 commit intomasterfrom
tests/issue-1186
Dec 10, 2021
Merged

added new spec for cancel login + login + logout#1202
sosnovsky merged 1 commit intomasterfrom
tests/issue-1186

Conversation

@fcvakintos
Copy link
Contributor

@fcvakintos fcvakintos commented Dec 10, 2021

This PR contains new spec for cancel login + login + logout, updated live config

close #1186

Tests

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub tomholub requested a review from sosnovsky December 10, 2021 12:53
@fcvakintos fcvakintos requested a review from tomholub December 10, 2021 12:56
@tomholub tomholub removed their request for review December 10, 2021 12:59
sosnovsky
sosnovsky approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@sosnovsky sosnovsky merged commit 4dfa409 into master Dec 10, 2021
@sosnovsky sosnovsky deleted the tests/issue-1186 branch December 10, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

appium test for canceling login

3 participants

@fcvakintos @sosnovsky @acladima