fix decrypt error rendering

[ivan-ushakov]

close #1144
close #1143 // tom edit

---

Tests (delete all except exactly one):

• Tests added or updated

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[tomholub]

just a note. I'm looking into it

[tomholub]

The Core is fine, and the longids are fine too, nothing to do with them.

The problem was that Swift could not parse the MsgBlock that was returned from TypeScript, and so it produced another block type blockParseErr which we were ignoring. Therefore empty message is rendered.

I've fixed the rendering of blockParseErr so now it shows as on screenshot below. Next step will be to also fix the reason why it was producing blockParseErr in the first place.

[tomholub]

The Core was returning back MsgBlock that could not be parsed (wrong types contained).

After fix:

[tomholub]

And here one more, tests will have to be updated.

[tomholub]

also mostly fixed #1143. The error was that while the text could be decrypted, the attachments were throwing decrypt errors. I've made it recognize decrypt errors and download the original file, but it needs another issue to actually render the decrypt error before downloading, make sure that's what the user wanted.

[tomholub]

This will need appium tests added and updated:

• update test of subject "encrypted - MDC hash mismatch - modification detected - should fail" to check for the error message
• update test of subject "not integrity protected - should show a warning and not decrypt automatically" to check for the error message
• add another email to verify: "key mismatch unexpectedly produces a modal" where you should now be able to successfully view email body

[tomholub]

@sosnovsky this is ready for your review on Monday. Thanks!