Skip to content

Added new specs for checking added recipients with attester api#1223

Merged
sosnovsky merged 4 commits intomasterfrom
tests/issue-736
Dec 14, 2021
Merged

Added new specs for checking added recipients with attester api#1223
sosnovsky merged 4 commits intomasterfrom
tests/issue-736

Conversation

@fcvakintos
Copy link
Contributor

@fcvakintos fcvakintos commented Dec 14, 2021

This PR contains new specs for checking attester mock api,added new method for checking added recipient color

close #736

Tests _

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub
Copy link
Collaborator

Agree with Roman's PR comments

@fcvakintos
Copy link
Contributor Author

@sosnovsky @tomholub fixed, pls check

@sosnovsky sosnovsky self-requested a review December 14, 2021 14:34
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@sosnovsky sosnovsky enabled auto-merge (squash) December 14, 2021 14:35
@sosnovsky sosnovsky merged commit e7a33d3 into master Dec 14, 2021
@sosnovsky sosnovsky deleted the tests/issue-736 branch December 14, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

testing that Attester search is disabled on some domains

4 participants