#1254 Send password-protected messages#1308
Merged
Conversation
# Conflicts: # FlowCrypt/Core/CoreHost.swift # FlowCrypt/Resources/flowcrypt-ios-prod.js.txt
tomholub
requested changes
Jan 13, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Code looks excellent, see comment below.
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageService.swift
Outdated
Show resolved
Hide resolved
Collaborator
|
The code structure is exactly what I'm familiar with 👍 so reviewing this was a breeze. |
Collaborator
Author
Yeah, having already implemented code structure in |
tomholub
reviewed
Jan 14, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
See my comment, else it's looking good.
FlowCrypt/Functionality/Services/Compose Message Service/ComposeMessageService.swift
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ability to send emails protected with password.
close #1254
Tests (delete all except exactly one):
encryptMsg -> parseDecryptMsg (with password)test forCoreandtest_sendable_msg_copyon iOSTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):