appium test for keeping public keys updated#1321
Merged
Conversation
sosnovsky
reviewed
Jan 21, 2022
sosnovsky
requested changes
Jan 21, 2022
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
Looks good now, just 1 small change needed
tomholub
reviewed
Jan 21, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Improvements, can be either here or in another PR.
Else looks good.
Comment on lines
+58
to
+61
| oldSignatureDate: 'Jan 12, 2022 at 11:16:58 AM',//time for CI runs | ||
| newSignatureDate: 'Jan 12, 2022 at 11:27:20 AM',//time for CI runs | ||
| // oldSignatureDate: 'Jan 12, 2022 at 9:16:58 PM', //- for local run | ||
| // newSignatureDate: 'Jan 12, 2022 at 9:27:20 PM', // for local run |
Collaborator
There was a problem hiding this comment.
That's not good. Can you make sure that tests always run the iOS app on UTC time, both locally and in CI?
Contributor
Author
There was a problem hiding this comment.
i think it is a timezone issue
Collaborator
There was a problem hiding this comment.
Of course it is a timezone issue. Can you set in appium runner to run the iOS simulator on UTC timezone regardless of the timezone of the host? There must be settings for it.
tomholub
changed the title
tomholub
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ce versa"
This PR contains new tests for "app updates older public keys to newer", added new screen for pubkey details, added new method for datahelper - convertDateToMsec, updated tests
close #1301
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):