Merged
Conversation
tomholub
previously approved these changes
Jan 20, 2022
Collaborator
tomholub
left a comment
There was a problem hiding this comment.
This looks good. That made me think: there are three types of attachments:
- plain / not encrypted
- encrypted as a separate file
- encrypted with pgp/mime (a mime message with attachments, encrypted whole)
Could you double check that the third case works after this change? Please try email with subject [enigmail] encrypted+signed+file PGP/MIME on flowcrypt.compatibiltiy account.
I supose the TS core will auto-decrypt it and return back as decrypted (plain), which should work. Worth checking though.
Collaborator
Author
|
Here is how it works in this branch Simulator.Screen.Recording.-.iPhone.13.-.2022-01-20.at.22.28.17.mp4Signature can't be verified, but I get the same error on |
Collaborator
Author
|
The same signature error is in browser extension, so should be good |
Collaborator
|
Looks perfect 👍 |
Collaborator
|
Just the tests to fix else looks great to me. |
tomholub
previously approved these changes
Jan 21, 2022
tomholub
approved these changes
Jan 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements attachments decrypt on tap, so they're not decrypted on message open.
close #1233
Tests (delete all except exactly one):
user is able to view message processing errorsanduser is able to view encrypted email with attachmenttestsTo be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):