Added method which converts signatureDate to UTC timezone#1344
Merged
Added method which converts signatureDate to UTC timezone#1344
Conversation
sosnovsky
reviewed
Jan 27, 2022
|
|
||
| await mockApi.withMockedApis(async () => { | ||
| const times = await driver.getDeviceTime(); | ||
| console.log('times', times); |
Collaborator
There was a problem hiding this comment.
Is it needed or was just for debug purpose?
Contributor
Author
There was a problem hiding this comment.
yes, i will remove it, sorry
Contributor
Author
There was a problem hiding this comment.
@sosnovsky can we skip test run after this update?
Collaborator
There was a problem hiding this comment.
Why skip it? I think it should pass without any issues
# Conflicts: # Podfile.lock
sosnovsky
approved these changes
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes for checkSignatureDateValue method, convert date to UTC timezone
close #1329
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):