Skip to content

#1363 Remove swiftformat from Makefile#1364

Merged
tomholub merged 1 commit intomasterfrom
feature/issue-1363-brew-install
Feb 4, 2022
Merged

#1363 Remove swiftformat from Makefile#1364
tomholub merged 1 commit intomasterfrom
feature/issue-1363-brew-install

Conversation

@sosnovsky
Copy link
Collaborator

This PR removes brew install swiftformat from Makefile as we're using swiftformat installed through Swift Package Manager, so there is no need to install it with homebrew

close #1363


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from tomholub February 4, 2022 15:16
@tomholub tomholub merged commit 3247987 into master Feb 4, 2022
@tomholub tomholub deleted the feature/issue-1363-brew-install branch February 4, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew not installed - include in make dependencies?

2 participants