Skip to content

Add aid for thread messages and added test for checking thread rendering#1395

Merged
tomholub merged 13 commits intomasterfrom
feature/issue-1370-aid
Mar 15, 2022
Merged

Add aid for thread messages and added test for checking thread rendering#1395
tomholub merged 13 commits intomasterfrom
feature/issue-1370-aid

Conversation

@Kharchevskyi
Copy link
Contributor

@Kharchevskyi Kharchevskyi commented Feb 21, 2022

This PR adds accessibility ids and add test for checking thread rendering, updated test after pushing new aids, added new methods for checking thread

close #1370
close #959

Tests

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@fcvakintos fcvakintos changed the base branch from master to test/issue-959 February 22, 2022 07:36
@fcvakintos
Copy link
Contributor

@tomholub I will fix the test on my branch

@fcvakintos fcvakintos marked this pull request as ready for review February 22, 2022 07:38
@tomholub
Copy link
Collaborator

@fcvakintos can you continue on this branch? or alternatively, close this PR but use the code in your own branch? I'm hesitant to merge a PR that doesn't pass tests.

@fcvakintos
Copy link
Contributor

@tomholub ok, will continue on this branch

@tomholub
Copy link
Collaborator

The git history seems unhappy - we will need to do something about it before merging. Maybe squashing the history first. Otherwise not possible to review.

@tomholub tomholub changed the base branch from test/issue-959 to master March 14, 2022 15:01
@FlowCrypt FlowCrypt deleted a comment from lgtm-com bot Mar 14, 2022
@FlowCrypt FlowCrypt deleted a comment from lgtm-com bot Mar 14, 2022
@FlowCrypt FlowCrypt deleted a comment from lgtm-com bot Mar 14, 2022
@fcvakintos fcvakintos changed the title Add aid for thread messages Add aid for thread messages and added test for checking thread rendering Mar 15, 2022
@tomholub tomholub merged commit 63d352e into master Mar 15, 2022
@tomholub tomholub deleted the feature/issue-1370-aid branch March 15, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add new accessibility id for thread messages ui tests for thread rendering

4 participants