added new spec for check recipients in offline mode#1432
Merged
Conversation
… for attster endpoints
tomholub
reviewed
Mar 21, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Looks good, please see comments for improvements
appium/tests/specs/mock/setup/CheckRecipientsInOfflineMode.spec.ts
Outdated
Show resolved
Hide resolved
tomholub
reviewed
Mar 22, 2022
Contributor
Author
|
@tomholub I found issue Screen.Recording.2022-03-23.at.14.39.51.mov |
Contributor
Author
|
@tomholub can i disable this test? |
Contributor
Author
|
@tomholub ok, sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains new spec for checking recipients in offline mode, added changes for attester-endpints file(added new method for returning error)
close #1420
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):