#1467 Load fesUrl only when needed

[sosnovsky]

This PR makes fesUrl a lazy property.

close #1467

---

Tests (delete all except exactly one):

• Tests added or updated

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[tomholub]

@sosnovsky I tried to resolve a conflict but broke it. Or maybe it's flakiness of tests.

[iPhone 13 iOS 15.4 #0-5] Running: iPhone 13 on iOS 15.4 executing /Users/semaphore/git/flowcrypt-ios/appium/FlowCrypt.app 39:24
[iPhone 13 iOS 15.4 #0-5] Session ID: fd5e992a-34df-4e8c-9f4d-b1109a0233ef 39:24
[iPhone 13 iOS 15.4 #0-5] 39:24
[iPhone 13 iOS 15.4 #0-5] » /tests/specs/live/composeEmail/RecipientListLabelCheck.spec.ts 39:24
[iPhone 13 iOS 15.4 #0-5] COMPOSE EMAIL: 39:24
[iPhone 13 iOS 15.4 #0-5]    ✖ should toggle recipient list label and show correct email addresses 39:24
  39:24
[iPhone 13 iOS 15.4 #0-5] 1 failing (1m 22.9s) 39:24
[iPhone 13 iOS 15.4 #0-5] 39:24
[iPhone 13 iOS 15.4 #0-5] 1) COMPOSE EMAIL:  should toggle recipient list label and show correct email addresses 39:24
[iPhone 13 iOS 15.4 #0-5] Error: Can't call setValue on element with selector "~aid-recipients-text-field-cc" because element wasn't found 39:24
[iPhone 13 iOS 15.4 #0-5] Error: Can't call setValue on element with selector "~aid-recipients-text-field-cc" because element wasn't found 39:24
[iPhone 13 iOS 15.4 #0-5]     at async NewMessageScreen.setAddRecipient (/Users/semaphore/git/flowcrypt-ios/appium/tests/screenobjects/new-message.screen.ts:134:7) 39:24
[iPhone 13 iOS 15.4 #0-5]     at async NewMessageScreen.composeEmail (/Users/semaphore/git/flowcrypt-ios/appium/tests/screenobjects/new-message.screen.ts:159:7) 39:24
[iPhone 13 iOS 15.4 #0-5]     at async UserContext.<anonymous> (/Users/semaphore/git/flowcrypt-ios/appium/tests/specs/live/composeEmail/RecipientListLabelCheck.spec.ts:33:5)

could consider a wait for that element before setting the value

[sosnovsky]

@sosnovsky I tried to resolve a conflict but broke it. Or maybe it's flakiness of tests.

Works well for me locally after merging latest changes from master

@tomholub why you decided to rollback to swiftpm v1? Did you get any issues after update?

[tomholub]

@sosnovsky I tried to resolve a conflict but broke it. Or maybe it's flakiness of tests.

Works well for me locally after merging latest changes from master

@tomholub why you decided to rollback to swiftpm v1? Did you get any issues after update?

I have hand-crafted the v2 file after a merge conflict (from master to this branch), and suspected I maybe have messed it up in the process. So I wanted to go with the safer choice of using the one I know works from master.

Otherwise have nothing against v2, it's probably good to upgrade, just wasn't sure the v2 file was correct after my interventions.

[sosnovsky]

Got it, Package.resolved is automatically reformatted when you open project in Xcode 13.3.
I'll push update in a few minutes