added new specs for checking EKM setup with revoked key#1526
Merged
added new specs for checking EKM setup with revoked key#1526
Conversation
tomholub
reviewed
Apr 26, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Test looks correct. Please check the formatting. Once it's passing, I can merge it in.
tomholub
reviewed
Apr 26, 2022
appium/tests/specs/mock/setup/SetupOnlyRevokedKeyFromEKM.spec.ts
Outdated
Show resolved
Hide resolved
tomholub
approved these changes
Apr 27, 2022
tomholub
changed the title
tomholub
previously approved these changes
Apr 27, 2022
tomholub
approved these changes
Apr 27, 2022
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Plus you also fixed the code formatting. Thanks
Collaborator
|
The way we solved this on other repos was with linters that run in CI. We did that here too, for TypeScript, but I suspect we didn't extend it to the /appium directory which we should. With a commit hook, I'm worried it may become another thing that may break and need to be maintained, but maybe it's just my lack of experience. We could consider that for later, if it works well and if Roma agrees. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 2 specs for checking EKM setup(checking sending message by user with only revoked private key and checking sending message by user with revoked and existing private key
close #1491
issue - added the comment for issue, we should not have error after sending email by user with and revoked and existing keys
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):