Skip to content

Feature/issue 193 attachments list#313

Merged
tomholub merged 10 commits intomasterfrom
feature/issue-193-attachmentsList
May 13, 2021
Merged

Feature/issue 193 attachments list#313
tomholub merged 10 commits intomasterfrom
feature/issue-193-attachmentsList

Conversation

@qsoftdevelopment
Copy link
Contributor

minor code refactoring

@qsoftdevelopment qsoftdevelopment marked this pull request as ready for review May 11, 2021 15:18
@qsoftdevelopment
Copy link
Contributor Author

There are 3 conflicts that need to be fixed. I will ping you in the morning once it has been finished.

@tomholub
Copy link
Collaborator

Emir won't be continuing with us. @Kharchevskyi please have a look at resolving the conflicts when you have a chance. Thanks!

@Kharchevskyi Kharchevskyi mentioned this pull request May 11, 2021
@Kharchevskyi
Copy link
Contributor

Simulator Screen Shot - iPhone 8 - 2021-05-13 at 12 51 31

@Kharchevskyi
Copy link
Contributor

@tomholub reworked functionality.

  • Removed Attachments node which was like a box for Attachment nodes.
  • Added second section to Message view controller where number of rows are equal to number of attachments.
  • Removed logical part from view controller to service

@Kharchevskyi Kharchevskyi requested a review from tomholub May 13, 2021 10:10
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomholub tomholub merged commit bdc5ec2 into master May 13, 2021
@tomholub tomholub deleted the feature/issue-193-attachmentsList branch May 13, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants