Feature/issue 314 costructing wkd urls#318
Merged
Conversation
tomholub
requested changes
May 17, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Please see comments below. Thanks!
FlowCryptTests/Functionallity/WKDURLs/WKDURLsConstructorTests.swift
Outdated
Show resolved
Hide resolved
FlowCryptTests/Functionallity/WKDURLs/WKDURLsConstructorTests.swift
Outdated
Show resolved
Hide resolved
tomholub
reviewed
May 17, 2021
Contributor
Author
|
@tomholub may I have an access to SemaphoreCI? There is a build is failing. |
Collaborator
|
I've added you - please try again. |
tomholub
approved these changes
May 17, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
It's looking good, one nitpick and it looks ready to merge.
| ) | ||
| } | ||
|
|
||
| func testEncryptedStringEncoding() throws { |
Collaborator
There was a problem hiding this comment.
Sha1 doesn't encrypt the data, it hashes it. So this would be testHashedStringEncoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZBase32 encoding implemented using open source solutions.
WKD URL construction was made based on Python implementation.
// edit tom: close #314