Skip to content

Cleanup user session on app start#353

Merged
tomholub merged 4 commits intomasterfrom
issue/351-logging-out
Jun 21, 2021
Merged

Cleanup user session on app start#353
tomholub merged 4 commits intomasterfrom
issue/351-logging-out

Conversation

@Kharchevskyi
Copy link
Contributor

@Kharchevskyi Kharchevskyi commented Jun 16, 2021

This PR Fix issue in case user hasn't finish setup and kill the app

close #351


Tests:

  • Difficult to test. This part requires to have all other parts to be covered with tests
  • Manual test

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@Kharchevskyi Kharchevskyi requested a review from tomholub June 16, 2021 21:25
@Kharchevskyi Kharchevskyi marked this pull request as ready for review June 17, 2021 08:40
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, will re-test

@Kharchevskyi
Copy link
Contributor Author

is it possible to prioritise #323 before merging this PR?

@tomholub
Copy link
Collaborator

Yes - definitely

@tomholub
Copy link
Collaborator

Please ping me once it has been brought up to date / conflicts resolved. Thanks!

@Kharchevskyi
Copy link
Contributor Author

Merged master. I haven't test all flows if it works with "new setup flow", but I assume it will.
(Going to check it probably tomorrow, or you can check and merge if everything works as expected)

Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code ok still, will check functionality now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should rename isAnyKey to doesAnyKeyExist - filing another issue

@tomholub
Copy link
Collaborator

works well

@tomholub tomholub merged commit 1b561af into master Jun 21, 2021
@tomholub tomholub deleted the issue/351-logging-out branch June 21, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unexpected behavior when logging out

2 participants