Merged
Conversation
Added fetching of ClientConfig that includes organisational rules; Fetching org rules on AppStartup;
ekievsky
commented
Jun 18, 2021
tomholub
reviewed
Jun 21, 2021
FlowCrypt/Functionality/Services/Organisational Rules Service/DomainRulesProvider.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Organisational Rules Service/OrganisationalRulesService.swift
Show resolved
Hide resolved
Collaborator
|
Sorry for the naming confusion earlier, I see we called it |
tomholub
requested changes
Jun 23, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Looks good - except for the code blunder
| guard let userDomain = email.recipientDomain, | ||
| func getClientConfiguration(for email: String) -> Promise<ClientConfiguration?> { | ||
| Promise<ClientConfiguration?> { resolve, _ in | ||
| guard let userDomain = "name@flowcrypt.com".recipientDomain, |
Collaborator
There was a problem hiding this comment.
Before marking a PR as ready for review, please do a self-review first on github. I do this for all code I push to GitHub before I ask others to review. This way you ensure that it is really ready for review and that bugs or temporary code was not left in the PR. Thanks!
Contributor
Author
There was a problem hiding this comment.
You're right, I should've been more careful. Sorry about that. I'll fix that shortly!
tomholub
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #276
Tests :
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):