Skip to content

Rename isAnyKey to doesAnyKeyExist#367

Merged
tomholub merged 1 commit intomasterfrom
bugfix/issue-364-naming
Jun 22, 2021
Merged

Rename isAnyKey to doesAnyKeyExist#367
tomholub merged 1 commit intomasterfrom
bugfix/issue-364-naming

Conversation

@Kharchevskyi
Copy link
Contributor

@Kharchevskyi Kharchevskyi commented Jun 22, 2021 •
edited by tomholub
Loading

This PR rename isAnyKey to doesAnyKeyExist

close #364

Tests:

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

tomholub
tomholub approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomholub tomholub merged commit ef16463 into master Jun 22, 2021
@tomholub tomholub deleted the bugfix/issue-364-naming branch June 22, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholub tomholub tomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rename isAnyKey to doesAnyKeyExist

2 participants

@Kharchevskyi @tomholub