Added comments to setup flow controllers#368
Merged
Conversation
tomholub
previously approved these changes
Jun 22, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Excellent - thank you.
This does not close the issue yet - please add similar comments to all view controllers. This will make reviews a lot easier. Thanks!
tomholub
reviewed
Jun 24, 2021
FlowCrypt/Controllers/Inbox/Container/InboxViewControllerContainer.swift
Outdated
Show resolved
Hide resolved
| * - User redirects here from SignInViewController | ||
| * - After successful connection user will be redirected to *main flow* | ||
| */ | ||
| final class EmailProviderViewController: TableNodeViewController { |
Collaborator
There was a problem hiding this comment.
We should call this SetupImapViewController ?
Contributor
Author
There was a problem hiding this comment.
Maybe better to call it SetupEmailProviderViewController? or if you think SetupImapViewController is better. naming - I'm ok with that as well
Collaborator
There was a problem hiding this comment.
This one is specifically for imap and smtp. I think email provider is too generic here. SetupImapViewController is preferred
tomholub
previously approved these changes
Jun 24, 2021
tomholub
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comments blocks to Setup Flow ViewControllers
issue #360
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):