Skip to content

Order of db deletion#389

Merged
tomholub merged 1 commit intomasterfrom
bugfix/issue-386-order-of-db-deletion
Jul 12, 2021
Merged

Order of db deletion#389
tomholub merged 1 commit intomasterfrom
bugfix/issue-386-order-of-db-deletion

Conversation

@ekievsky
Copy link
Contributor

@ekievsky ekievsky commented Jul 12, 2021

This PR moved removing of client config before user deletion while logging out;

close #386


Tests:

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ekievsky
Copy link
Contributor Author

It was not causing a crash, but I moved it for sanity and consistency.

@tomholub tomholub merged commit 120d246 into master Jul 12, 2021
@tomholub tomholub deleted the bugfix/issue-386-order-of-db-deletion branch July 12, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix order of db deletions during logout

3 participants