Conversation
tomholub
approved these changes
Jul 23, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Looks good. If the app starts crashing on one of these, then we have learned something and can properly adjust the code.
tomholub
deleted the
feature/issue-387-replace-assertion-with-fatal-error-services
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces assertion failures with fatal errors in appropriate services;
close #387
Tests :
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):