Conversation
tomholub
left a comment
There was a problem hiding this comment.
-> did I receive a response and it's other status 4xx or 5xx? -> show error to user
Where was this implemented?
-> did I NOT receive a response (server down or timeout) and the internet is otherwise working? -> don't use FES, empty OrgRules
Where was this implemented?
-> did I NOT receive a response (server down or timeout) and the internet is not working? -> show error to user
Where was this implemented?
This PR only addresses 20% of the requirements that were clearly laid out in the issue. If the PR addresses less then all requirements of an issue, you must clearly highlight which parts you addressed, and don't close the issue in the PR description.
| static let getToleratedHTTPStatuses = [404] | ||
| /// -1001 - request timed out, -1003 - сannot resolve host | ||
| static let getToleratedNSErrorCodes = [-1001, -1003] | ||
| static let getActiveFesTimeout: TimeInterval = 100 |
There was a problem hiding this comment.
Should also tolerate the following, which all are related to server down
kCFURLErrorCannotConnectToHost = -1004,
kCFURLErrorNetworkConnectionLost = -1005,
kCFURLErrorDNSLookupFailed = -1006,
kCFURLErrorHTTPTooManyRedirects = -1007,
kCFURLErrorResourceUnavailable = -1008,
| static let getToleratedHTTPStatuses = [404] | ||
| /// -1001 - request timed out, -1003 - сannot resolve host | ||
| static let getToleratedNSErrorCodes = [-1001, -1003] | ||
| static let getActiveFesTimeout: TimeInterval = 100 |
There was a problem hiding this comment.
Also, what is the number 100 here, 100 seconds? Milliseconds?
There was a problem hiding this comment.
for some reason my lates commit wasn't included :/
…onal-rules-calling-fes
This PR tolerates not found, timeout, service unavailable errors in EnterpriseService;
close #408
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):