Merged
Conversation
tomholub
requested changes
Aug 9, 2021
FlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Controllers/Setup/SetupCreatePassphraseViewController.swift
Outdated
Show resolved
Hide resolved
Fixed PR comments;
…lowCrypt/flowcrypt-ios into feature/issue-279-passphrase-setup-ekm
Collaborator
|
It's progressing well. For comments that you have addressed, please click "Resolve conversation" after you have pushed the appropriate commit, to make it clear which ones were addressed and which not. |
tomholub
reviewed
Aug 14, 2021
tomholub
approved these changes
Aug 15, 2021
Collaborator
tomholub
left a comment
There was a problem hiding this comment.
All looks good. Code is clear and well structured. Functionality works now.
In the future, more careful studying of the issue definition and larger context will help you code with more confidence, and reduce my workload when reviewing.
Thank you.
Collaborator
|
To clarify, it still holds that in cases when the issue is not well defined, asking questions is way better then guessing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds passphrase setup with ekmkes
close #279
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):