Split UI Tests into Gmail vs Imap tests#437
Conversation
FlowCrypt/Functionality/Services/Folders Services/RemoteFoldersProviderType/Imap+folders.swift
Show resolved
Hide resolved
| // Used for ui tests | ||
| if user.email.contains("default@flowcrypt.test") { | ||
| user.imap?.connectionType = "none" | ||
| } |
There was a problem hiding this comment.
What does "none" here mean and what are the other possible values?
There was a problem hiding this comment.
We use providers.json to pre fill imap/smtp settings. Unfortunately it's not possible for mailcore lib to prefill with none value. Only starttls/ssl: true/false can be specified.
There was a problem hiding this comment.
Why not set this through the UI in the test code? It's a UI test after all, it's expected to interact with UI elements during the tests.
There was a problem hiding this comment.
Without this lines we will prefill with tls selected by default. (returned by default from mailcore).
If we change it after to none this will prefill with 143 port (default value from mailcore for none security type).
so then we need to change port as well both for imap and smtp.
This can be done on UI tests level, but this is a bit more time consuming and less stable
There was a problem hiding this comment.
I understand what you mean. Definitely we should use the UI for this. If it's less stable, we should over time find a way to improve the tests to make them more stable. It's possible for UI tests to be reasonably stable too, it just takes some work.
There was a problem hiding this comment.
What I worried about that there are a lot of bugs inside xcode with ui tests.
For example, sometimes password text field should be tapped once to show keyboard and sometimes it works only from second tap.
let passwordTextField = app.tables.secureTextFields["Password"]
passwordTextField.tap()
passwordTextField.tap()
Will work on it(will mark as draft for now)
There was a problem hiding this comment.
Understood. Hopefully we can work around all of this.
FlowCrypt/Functionality/Services/Folders Services/RemoteFoldersProviderType/Imap+folders.swift
Show resolved
Hide resolved
|
@Kharchevskyi please also update the PR template - the Tests section to reflect what was done in the PR. It's good to do this consistently to build a habit. |
|
lgtm |
|
please look at #439 next |
2 participants
This PR:
close #425
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):