Conversation
tomholub
reviewed
Sep 10, 2021
tomholub
reviewed
Sep 17, 2021
FlowCryptAppTests/Functionallity/OrganisationalRulesTests.swift
Outdated
Show resolved
Hide resolved
…ure/issue-498-ekm-tests
Kharchevskyi
commented
Sep 21, 2021
...s/Functionallity/Services/Organisational Rules Service/OrganisationalRulesServiceTests.swift
Show resolved
Hide resolved
tomholub
approved these changes
Sep 21, 2021
...ts/Functionallity/Services/Organisational Rules Service/ClientConfigurationServiceTest.swift
Show resolved
Hide resolved
...ts/Functionallity/Services/Organisational Rules Service/ClientConfigurationServiceTest.swift
Show resolved
Hide resolved
...pTests/Functionallity/Services/Organisational Rules Service/Mocks/CurrentUserEmailMock.swift
Show resolved
Hide resolved
This was referenced Sep 21, 2021
tomholub
requested changes
Sep 21, 2021
Collaborator
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Missing test check as above - else ok
Collaborator
|
@Kharchevskyi after this PR, please look into the database schema changes. After that, I should be ready to make a testflight release. |
Collaborator
|
@Kharchevskyi correction - first need to do this one: #516 and after that the database changes |
Collaborator
|
@Kharchevskyi please have a look to finalize when you have a chance |
Contributor
Author
|
Will check asap. |
Collaborator
Understood - please give me more advanced notice whenever possible, so I can organize appropriately. Thanks! |
…ure/issue-498-ekm-tests
…owcrypt-ios into feature/issue-498-ekm-tests
tomholub
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for ekm integration
close #498
Tests:
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):